« ^ »

sqlfluffのHomebrew Formulaを書いた

所要時間: 約 4分

SQL Cookbook 第2版が出版されることになり、私は技術監修としてお声がかかった。それに伴ってSQLのフォーマッターを探していた。いくつかフォーマッターはある。その中でsqlfluffというSQLのフォーマッターの使用感が良かった。sqlfluffはPythonで実装されている。sqlfluffの公式ドキュメントにはpipを用いたインストール方法が記述されている。私はプロジェクトを跨いで使用するようなツールはHomebrewを使ってインストールしているが、HomebrewにはsqlfluffのFormulaが無く brew install sqlfluff としてインストールできなかった。 そのためFormulaを追加することにした。その内Pull requestを出そうとはおもうが、取り敢えず自分用のFormulaとして書いた。

https://github.com/TakesxiSximada/homebrew-tap/pull/1

(これと同様の修正は本家に後に出した)

追記 (2021-12-04)

追記 (2021-12-24)

PRがマージされた。以下でインストールできる。

brew install sqlfluff

作業メモ

以下はその時の作業メモ。

brew createを使ってFormulaを生成する。

brew create --python https://files.pythonhosted.org/packages/3b/1b/1b6a4b9e35e2884651f94ccc31f96a8cb5fde57c2c531767b12d561c8377/sqlfluff-0.8.2.tar.gz
bash-5.1$ brew create --tap takesxisximada/homebrew-core --python https://files.pythonhosted.org/packages/3b/1b/1b6a4b9e35e2884651f94ccc31f96a8cb5fde57c2c531767b12d561c8377/sqlfluff-0.8.2.tar.gz
==> Downloading https://files.pythonhosted.org/packages/3b/1b/1b6a4b9e35e2884651f94ccc31f96a8cb5fdeAlready downloaded: /Users/sximada/Library/Caches/Homebrew/downloads/9b2320c2cfd32f31c58afca3eb78d70e17d4f3663fbadfed917951f116aa79f7--sqlfluff-0.8.2.tar.gz
Warning: Cannot verify integrity of '9b2320c2cfd32f31c58afca3eb78d70e17d4f3663fbadfed917951f116aa79f7--sqlfluff-0.8.2.tar.gz'.
No checksum was provided for this resource.
For your reference, the checksum is:
  sha256 "e48db0e1f7775c4609aa843cc8fa7fbc4a42d38fef640a78cc33d335ad385c62"
==> Retrieving PyPI dependencies for "sqlfluff==0.8.2"...
==> Getting PyPI info for "appdirs==1.4.4"
==> Getting PyPI info for "attrs==21.2.0"
==> Getting PyPI info for "cached-property==1.5.2"
==> Getting PyPI info for "chardet==4.0.0"
==> Getting PyPI info for "click==8.0.3"
==> Getting PyPI info for "colorama==0.4.4"
==> Getting PyPI info for "configparser==5.2.0"
==> Getting PyPI info for "diff-cover==6.4.3"
==> Getting PyPI info for "iniconfig==1.1.1"
==> Getting PyPI info for "jinja2==3.0.3"
==> Getting PyPI info for "markupsafe==2.0.1"
==> Getting PyPI info for "oyaml==1.0"
==> Getting PyPI info for "packaging==21.3"
==> Getting PyPI info for "pathspec==0.9.0"
==> Getting PyPI info for "pluggy==1.0.0"
==> Getting PyPI info for "py==1.11.0"
==> Getting PyPI info for "pygments==2.10.0"
==> Getting PyPI info for "pyparsing==3.0.6"
==> Getting PyPI info for "pytest==6.2.5"
==> Getting PyPI info for "pyyaml==6.0"
==> Excluding "sqlfluff==0.8.2"
==> Getting PyPI info for "tblib==1.7.0"
==> Getting PyPI info for "toml==0.10.2"
==> Getting PyPI info for "tqdm==4.62.3"
==> Getting PyPI info for "typing-extensions==4.0.1"
==> Updating resource blocks
Please run `brew audit --new sqlfluff` before submitting, thanks.
Editing /usr/local/Homebrew/Library/Taps/takesxisximada/homebrew-core/Formula/sqlfluff.rb
Warning: Using vim because no editor was set in the environment.
This may change in the future, so we recommend setting EDITOR,
or HOMEBREW_EDITOR to your preferred text editor.

依存するパッケージを指定するが、depends_onにpygmentsを含めて実行したところエラーが発生した。

bash-5.1$ brew install --build-from-source sqlfluff
==> Downloading https://ghcr.io/v2/homebrew/core/pygments/manifests/2.10.0_1
######################################################################## 100.0%
==> Downloading https://ghcr.io/v2/homebrew/core/pygments/blobs/sha256:7095fda62baec826a619282cd127==> Downloading from https://pkg-containers.githubusercontent.com/ghcr1/blobs/sha256:7095fda62baec8######################################################################## 100.0%
==> Downloading https://files.pythonhosted.org/packages/d7/d8/05696357e0311f5b5c316d7b95f46c669dd9cAlready downloaded: /Users/sximada/Library/Caches/Homebrew/downloads/d46628d315f103ea527907020cf5f6c94365bbb549783f75a794526482afb672--appdirs-1.4.4.tar.gz
==> Downloading https://files.pythonhosted.org/packages/ed/d6/3ebca4ca65157c12bd08a63e20ac0bdc21ac7Already downloaded: /Users/sximada/Library/Caches/Homebrew/downloads/5cda51dfa0370b73c9dd89bc880bc12efe82b068297e83e79bb96827dccd14a8--attrs-21.2.0.tar.gz
==> Downloading https://files.pythonhosted.org/packages/61/2c/d21c1c23c2895c091fa7a91a54b6872098feaAlready downloaded: /Users/sximada/Library/Caches/Homebrew/downloads/9af45ac86aad4fc6f65851247727f483aeea4e37f68542a8246254443ff5ef83--cached-property-1.5.2.tar.gz
==> Downloading https://files.pythonhosted.org/packages/ee/2d/9cdc2b527e127b4c9db64b86647d567985940Already downloaded: /Users/sximada/Library/Caches/Homebrew/downloads/51522c1f11159adb9f042370134bd27b149ad2fbc237e8110785b0beccd23444--chardet-4.0.0.tar.gz
==> Downloading https://files.pythonhosted.org/packages/f4/09/ad003f1e3428017d1c3da4ccc9547591703ffAlready downloaded: /Users/sximada/Library/Caches/Homebrew/downloads/c482daa26aae9d70548634c84422aca19995965279d88db8397769d0685d3261--click-8.0.3.tar.gz
==> Downloading https://files.pythonhosted.org/packages/1f/bb/5d3246097ab77fa083a61bd8d3d527b7ae063Already downloaded: /Users/sximada/Library/Caches/Homebrew/downloads/e7330193254dd730e7650c6e56161b9c00ccada445384cda90e60194c734a7a4--colorama-0.4.4.tar.gz
==> Downloading https://files.pythonhosted.org/packages/02/a8/5fae273a45a3e4e34ea560c99a4843fe2d9fcAlready downloaded: /Users/sximada/Library/Caches/Homebrew/downloads/86d79abf84134175123e8aa8a5adf5ad3fdeee616e30ae6bd7c285370aa02fff--configparser-5.2.0.tar.gz
==> Downloading https://files.pythonhosted.org/packages/19/0a/32489dbdf5eed5d4e1ed4201227648d1f62f6Already downloaded: /Users/sximada/Library/Caches/Homebrew/downloads/9e2d8e97e5d67f439224006fc6a8e575b05c81354cc9f4f377586160e9bd8dd4--diff_cover-6.4.3.tar.gz
==> Downloading https://files.pythonhosted.org/packages/23/a2/97899f6bd0e873fed3a7e67ae8d3a08b21799Already downloaded: /Users/sximada/Library/Caches/Homebrew/downloads/7e40cf4494c6e66602ea4d121fc7266762a8d09bf5c1fac5d82f5c6d63b693e5--iniconfig-1.1.1.tar.gz
==> Downloading https://files.pythonhosted.org/packages/91/a5/429efc6246119e1e3fbf562c00187d04e83e5Already downloaded: /Users/sximada/Library/Caches/Homebrew/downloads/9459b28e4118d509c4c03ad0168a5c125d5446c824380fd5bb36050751f4f465--Jinja2-3.0.3.tar.gz
==> Downloading https://files.pythonhosted.org/packages/bf/10/ff66fea6d1788c458663a84d88787bae15d45Already downloaded: /Users/sximada/Library/Caches/Homebrew/downloads/2f2488b4acce3f0f78d8d8a234cbcc0306b6789e9b18ada8269380a59131b350--MarkupSafe-2.0.1.tar.gz
==> Downloading https://files.pythonhosted.org/packages/00/71/c721b9a524f6fe6f73469c90ec44784f0b2b1Already downloaded: /Users/sximada/Library/Caches/Homebrew/downloads/c70921e6398f61493e301f0c6b01861d88bd52d5edd592ae75e138662ac7b828--oyaml-1.0.tar.gz
==> Downloading https://files.pythonhosted.org/packages/df/9e/d1a7217f69310c1db8fdf8ab396229f55a699Already downloaded: /Users/sximada/Library/Caches/Homebrew/downloads/4e5cc302ac2525105e67cdfb598d16c5dd68105f5501546cc69887ddb63d6676--packaging-21.3.tar.gz
==> Downloading https://files.pythonhosted.org/packages/f6/33/436c5cb94e9f8902e59d1d544eb298b83c84bAlready downloaded: /Users/sximada/Library/Caches/Homebrew/downloads/72a8248f382acf6ccd4466a3fa81ac151107cdee27c1fe61450bbe2faa0f4976--pathspec-0.9.0.tar.gz
==> Downloading https://files.pythonhosted.org/packages/a1/16/db2d7de3474b6e37cbb9c008965ee63835bbaAlready downloaded: /Users/sximada/Library/Caches/Homebrew/downloads/febf027706f4a14855b904617ce2f90e1d6501d9b18303327bafa3a090b2159e--pluggy-1.0.0.tar.gz
==> Downloading https://files.pythonhosted.org/packages/98/ff/fec109ceb715d2a6b4c4a85a61af3b40c723aAlready downloaded: /Users/sximada/Library/Caches/Homebrew/downloads/90ac9ad243cc4d0be7bde71dfda561be614aefb237e384adc640f21bf0e35b3f--py-1.11.0.tar.gz
==> Downloading https://files.pythonhosted.org/packages/ab/61/1a1613e3dcca483a7aa9d446cb4614e6425eb
Already downloaded: /Users/sximada/Library/Caches/Homebrew/downloads/2b06c6a32c0063a0027222c6ca4bfc
f47c88d002a300c53e708426e99c30ee44--pyparsing-3.0.6.tar.gz
==> Downloading https://files.pythonhosted.org/packages/4b/24/7d1f2d2537de114bdf1e6875115113ca80091
Already downloaded: /Users/sximada/Library/Caches/Homebrew/downloads/ccf484cb6748fc101b6734f85f0c56
d2f4cf899a4cdede5d2a761b401d61eedf--pytest-6.2.5.tar.gz
==> Downloading https://files.pythonhosted.org/packages/36/2b/61d51a2c4f25ef062ae3f74576b01638bebad
Already downloaded: /Users/sximada/Library/Caches/Homebrew/downloads/83f6bef3a0a4fd3d9559a85acb4ab7
3b0e4544f8542e67bf54929e86653356e9--PyYAML-6.0.tar.gz
==> Downloading https://files.pythonhosted.org/packages/d3/41/901ef2e81d7b1e834b9870d416cb09479e175
Already downloaded: /Users/sximada/Library/Caches/Homebrew/downloads/6ca432be4226207706c14f3ac3ccd5
e6b651422f5462513b908e955201916a0d--tblib-1.7.0.tar.gz
==> Downloading https://files.pythonhosted.org/packages/be/ba/1f744cdc819428fc6b5084ec34d9b30660f6f
Already downloaded: /Users/sximada/Library/Caches/Homebrew/downloads/da183683db0d24e1635190f4f24997
82f0901d7f1e58211b783f1f863b5b4b68--toml-0.10.2.tar.gz
==> Downloading https://files.pythonhosted.org/packages/e3/c1/b3e42d5b659ca598508e2a9ef315d5eef0a97
Already downloaded: /Users/sximada/Library/Caches/Homebrew/downloads/8881ebe64faade91415735eeb2c0ec
e8fafa29c98810ada82f24758575906630--tqdm-4.62.3.tar.gz
==> Downloading https://files.pythonhosted.org/packages/0d/4a/60ba3706797b878016f16edc5fbaf1e222109
Already downloaded: /Users/sximada/Library/Caches/Homebrew/downloads/afdb51418f7b4bd3b2b3d952dc96e8
427aa98765791f793fcbd412e51f585a63--typing_extensions-4.0.1.tar.gz
==> Downloading https://files.pythonhosted.org/packages/3b/1b/1b6a4b9e35e2884651f94ccc31f96a8cb5fde
Already downloaded: /Users/sximada/Library/Caches/Homebrew/downloads/9b2320c2cfd32f31c58afca3eb78d7
0e17d4f3663fbadfed917951f116aa79f7--sqlfluff-0.8.2.tar.gz
Warning: A newer Command Line Tools release is available.
Update them from Software Update in System Preferences or run:
  softwareupdate --all --install --force

If that doesn't show you any updates, run:
  sudo rm -rf /Library/Developer/CommandLineTools
  sudo xcode-select --install

Alternatively, manually download them from:
  https://developer.apple.com/download/all/.
You should download the Command Line Tools for Xcode 13.1.

==> Installing dependencies for sqlfluff: pygments
==> Installing sqlfluff dependency: pygments
==> Pouring pygments--2.10.0_1.big_sur.bottle.tar.gz
🍺  /usr/local/Cellar/pygments/2.10.0_1: 847 files, 11.6MB
==> Installing sqlfluff
==> python3.10 -m venv --system-site-packages /usr/local/Cellar/sqlfluff/0.8.2/libexec
==> /usr/local/Cellar/sqlfluff/0.8.2/libexec/bin/pip install -v --no-deps --no-binary :all: --ignor
==> /usr/local/Cellar/sqlfluff/0.8.2/libexec/bin/pip install -v --no-deps --no-binary :all: --ignor

==> /usr/local/Cellar/sqlfluff/0.8.2/libexec/bin/pip install -v --no-deps --no-binary :all: --ignor
==> /usr/local/Cellar/sqlfluff/0.8.2/libexec/bin/pip install -v --no-deps --no-binary :all: --ignor
==> /usr/local/Cellar/sqlfluff/0.8.2/libexec/bin/pip install -v --no-deps --no-binary :all: --ignor
==> /usr/local/Cellar/sqlfluff/0.8.2/libexec/bin/pip install -v --no-deps --no-binary :all: --ignor
==> /usr/local/Cellar/sqlfluff/0.8.2/libexec/bin/pip install -v --no-deps --no-binary :all: --ignor
==> /usr/local/Cellar/sqlfluff/0.8.2/libexec/bin/pip install -v --no-deps --no-binary :all: --ignor
==> /usr/local/Cellar/sqlfluff/0.8.2/libexec/bin/pip install -v --no-deps --no-binary :all: --ignor
==> /usr/local/Cellar/sqlfluff/0.8.2/libexec/bin/pip install -v --no-deps --no-binary :all: --ignor
==> /usr/local/Cellar/sqlfluff/0.8.2/libexec/bin/pip install -v --no-deps --no-binary :all: --ignor
==> /usr/local/Cellar/sqlfluff/0.8.2/libexec/bin/pip install -v --no-deps --no-binary :all: --ignor
==> /usr/local/Cellar/sqlfluff/0.8.2/libexec/bin/pip install -v --no-deps --no-binary :all: --ignor
==> /usr/local/Cellar/sqlfluff/0.8.2/libexec/bin/pip install -v --no-deps --no-binary :all: --ignor
==> /usr/local/Cellar/sqlfluff/0.8.2/libexec/bin/pip install -v --no-deps --no-binary :all: --ignor
==> /usr/local/Cellar/sqlfluff/0.8.2/libexec/bin/pip install -v --no-deps --no-binary :all: --ignor
==> /usr/local/Cellar/sqlfluff/0.8.2/libexec/bin/pip install -v --no-deps --no-binary :all: --ignor
==> /usr/local/Cellar/sqlfluff/0.8.2/libexec/bin/pip install -v --no-deps --no-binary :all: --ignor
==> /usr/local/Cellar/sqlfluff/0.8.2/libexec/bin/pip install -v --no-deps --no-binary :all: --ignor

==> /usr/local/Cellar/sqlfluff/0.8.2/libexec/bin/pip install -v --no-deps --no-binary :all: --ignor
==> /usr/local/Cellar/sqlfluff/0.8.2/libexec/bin/pip install -v --no-deps --no-binary :all: --ignor
==> /usr/local/Cellar/sqlfluff/0.8.2/libexec/bin/pip install -v --no-deps --no-binary :all: --ignor
==> /usr/local/Cellar/sqlfluff/0.8.2/libexec/bin/pip install -v --no-deps --no-binary :all: --ignor
==> /usr/local/Cellar/sqlfluff/0.8.2/libexec/bin/pip install -v --no-deps --no-binary :all: --ignor
🍺  /usr/local/Cellar/sqlfluff/0.8.2: 2,306 files, 23.7MB, built in 7 minutes 51 seconds
==> Running `brew cleanup sqlfluff`...
Disable this behaviour by setting HOMEBREW_NO_INSTALL_CLEANUP.
Hide these hints with HOMEBREW_NO_ENV_HINTS (see `man brew`).
bash-5.1$ brew test sqlfluff
==> Testing sqlfluff
==> /usr/local/Cellar/sqlfluff/0.8.2/bin/sqlfluff --version
Traceback (most recent call last):
  File "/usr/local/Cellar/sqlfluff/0.8.2/bin/sqlfluff", line 33, in <module>
    sys.exit(load_entry_point('sqlfluff==0.8.2', 'console_scripts', 'sqlfluff')())
  File "/usr/local/Cellar/sqlfluff/0.8.2/bin/sqlfluff", line 25, in importlib_load_entry_point
    return next(matches).load()
  File "/usr/local/Cellar/[email protected]/3.10.0_2/Frameworks/Python.framework/Versions/3.10/lib/python3.10/importlib/metadata/__init__.py", line 162, in load
    module = import_module(match.group('module'))
  File "/usr/local/Cellar/[email protected]/3.10.0_2/Frameworks/Python.framework/Versions/3.10/lib/python3.10/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 992, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 992, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/usr/local/Cellar/sqlfluff/0.8.2/libexec/lib/python3.10/site-packages/sqlfluff/__init__.py", line 9, in <module>
    import pkg_resources
  File "/usr/local/Cellar/sqlfluff/0.8.2/libexec/lib/python3.10/site-packages/pkg_resources/__init__.py", line 3243, in <module>
    def _initialize_master_working_set():
  File "/usr/local/Cellar/sqlfluff/0.8.2/libexec/lib/python3.10/site-packages/pkg_resources/__init_    f(*args, **kwargs)
  File "/usr/local/Cellar/sqlfluff/0.8.2/libexec/lib/python3.10/site-packages/pkg_resources/__init_    working_set = WorkingSet._build_master()
  File "/usr/local/Cellar/sqlfluff/0.8.2/libexec/lib/python3.10/site-packages/pkg_resources/__init_    ws.require(__requires__)
  File "/usr/local/Cellar/sqlfluff/0.8.2/libexec/lib/python3.10/site-packages/pkg_resources/__init_    needed = self.resolve(parse_requirements(requirements))
  File "/usr/local/Cellar/sqlfluff/0.8.2/libexec/lib/python3.10/site-packages/pkg_resources/__init_    raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The 'Pygments<3.0.0,>=2.9.0' distribution was not found and is Error: sqlfluff: failed
An exception occurred within a child process:
  Minitest::Assertion: Expected: 0
  Actual: 1
/usr/local/Homebrew/Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/minitest-5.14.4/lib/minitest/ass/usr/local/Homebrew/Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/minitest-5.14.4/lib/minitest/ass/usr/local/Homebrew/Library/Homebrew/formula_assertions.rb:26:in `shell_output'
/usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/sqlfluff.rb:133:in `block in <class/usr/local/Homebrew/Library/Homebrew/formula.rb:2106:in `block (3 levels) in run_test'
/usr/local/Homebrew/Library/Homebrew/utils.rb:588:in `with_env'
/usr/local/Homebrew/Library/Homebrew/formula.rb:2105:in `block (2 levels) in run_test'
/usr/local/Homebrew/Library/Homebrew/formula.rb:949:in `with_logging'
/usr/local/Homebrew/Library/Homebrew/formula.rb:2104:in `block in run_test'
/usr/local/Homebrew/Library/Homebrew/mktemp.rb:63:in `block in run'
/usr/local/Homebrew/Library/Homebrew/mktemp.rb:63:in `chdir'
/usr/local/Homebrew/Library/Homebrew/mktemp.rb:63:in `run'
/usr/local/Homebrew/Library/Homebrew/formula.rb:2357:in `mktemp'
/usr/local/Homebrew/Library/Homebrew/formula.rb:2098:in `run_test'
/usr/local/Homebrew/Library/Homebrew/test.rb:43:in `block in <main>'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.8/lib/ruby/2.6.0/timeout.rb:93:in `bl/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.8/lib/ruby/2.6.0/timeout.rb:33:in `bl/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.8/lib/ruby/2.6.0/timeout.rb:33:in `ca/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.8/lib/ruby/2.6.0/timeout.rb:33:in `ca/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.8/lib/ruby/2.6.0/timeout.rb:108:in `t/usr/local/Homebrew/Library/Homebrew/test.rb:48:in `<main>'
bash-5.1$ python3.10
bash: python3.10: command not found
bash-5.1$ ls /usr/local/Cellar/[email protected]/3.10.0_2/Frameworks/Python.framework/Versions/3.10/
Headers         Python          Resources       bin             include         lib             shabash-5.1$ /usr/local/Cellar/[email protected]/3.10.0_2/Frameworks/Python.framework/Versions/3.10/bin/pythbash: /usr/local/Cellar/[email protected]/3.10.0_2/Frameworks/Python.framework/Versions/3.10/bin/python: bash-5.1$ /usr/local/Cellar/[email protected]/3.10.0_2/Frameworks/Python.framework/Versions/3.10/bin/pythPython 3.10.0 (default, Oct 13 2021, 06:45:00) [Clang 13.0.0 (clang-1300.0.29.3)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import pygments
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ModuleNotFoundError: No module named 'pygments'
>>> import pygment
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ModuleNotFoundError: No module named 'pygment'

そのためdepends_onにはpygmentsを指定しないようにした。

HomebrewのFormulaの追加には、以下の記事が参考になった。

https://dev.classmethod.jp/articles/new-formula-request-to-homebrew/

Pull requestを作成した後はすぐにコメントを頂いた。

https://github.com/Homebrew/homebrew-core/pull/90418#discussion_r762403873

指摘された箇所を修正し再度レビューを依頼した。

再レビューを依頼してから、レビューされるまでにだいたい18日かかった。 Homebrewのメンテナンスを行っている方のリソースによるものだ。 スピード的にはすごい勢いでレビューしているようにも思えるが、作成されるPRの量がそれ以上に多いのでどうしても時間がかかってしまう。 そのため気長に待とう。